Re: [PATCH] blk-mq: avoid double ->queue_rq() because of early timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ming Lei <ming.lei@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH] blk-mq: avoid double ->queue_rq() because of early timeout
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Tue, 25 Oct 2022 07:04:07 -0700
Cc: linux-block@xxxxxxxxxxxxxxx, David Jeffery <djeffery@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20221025005501.281460-1-ming.lei@redhat.com>
References: <20221025005501.281460-1-ming.lei@redhat.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0

On 10/24/22 17:55, Ming Lei wrote:

+struct blk_expired_data {
+	unsigned long next;
+	unsigned long now;
+};


How about renaming 'now' into 'before_quiesce'? Anyway:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>

References:
- [PATCH] blk-mq: avoid double ->queue_rq() because of early timeout
  - From: Ming Lei

Prev by Date: Re: [PATCH] blk-mq: avoid double ->queue_rq() because of early timeout
Next by Date: Re: [PATCH 1/4] blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue
Previous by thread: Re: [PATCH] blk-mq: avoid double ->queue_rq() because of early timeout
Next by thread: Re: [PATCH] blk-mq: avoid double ->queue_rq() because of early timeout
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux