On Fri, Oct 21, 2022 at 09:46:33AM +0800, Ming Lei wrote: > The change is fine, but the interface could confuse people, it > looks like it is waiting for whole tagset quiesced, but it needs > to mark all request queues as quiesced first, otherwise it is just > wait for one specific queue's quiesce. > > So suggest to document such thing. Yes, that's probably a good idea. Still better would be to make this API purely internal, as the pure wait callers in NVMe and SCSI are a bit sketchy.