Damien, MODULE_PARM_DESC(zone_max_active, "Maximum number of active zones when block device is zoned. Default: 0 (no limit)"); >>>> >>>> +static bool g_zone_reset_all = true; >>>> +module_param_named(zone_reset_all, g_zone_reset_all, bool, 0444); >>> >>> Nit: Why read-only ? You can make it writable without any issue, no ? >>> >> >> Sorry I didn't understand this comment. In case this comment is about >> new zone_reset_all modpram being readonly and not allowed to set via >> command line? The test log shows I was able to set it to 0 and trigger >> call to blkdev_zone_reset_all_emulated() and default behavior ends up >> calling blkdev_zone_reset_all(). >> >> -ck >> > > If you change the param mode to 644, one can do: > > echo 0 >/sys/module/null_blk/parameters/zone_reset_all > or > echo 1 >/sys/module/null_blk/parameters/zone_reset_all > > But given that all null_blk parameters are read-only, not a big deal. > if you are okay with this can I get your reviewed-by ? -ck
