On Tue, Oct 18 2022 at 2:17P -0400, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Tue, Oct 18, 2022 at 12:20:50PM -0400, Mike Snitzer wrote: > > > > - Enhance DM ioctl interface to allow returning an error string to > > userspace. Depends on exporting is_vmalloc_or_module_addr() to allow > > DM core to conditionally free memory allocated with kasprintf(). > > That really does not sound like a good idea at all. And it does not > seem to have any MM or core maintainer signoffs. Sorry, I should've solicited proper review more loudly. But if you have a specific concern with how DM is looking to use is_vmalloc_or_module_addr() please say what that is. Mike