On Mon, Oct 17, 2022 at 07:16:56PM +0300, Serge Semin wrote: > Please note the applied patch doesn't comply with the Keith' notes > Link: https://lore.kernel.org/linux-nvme/YzxueNRODpry8L0%2F@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > Meanwhile without patch #1 (having only the accepted by you patch > applied) the NVME hwmon init now seems contradicting: it ignores one > kmalloc failure (returns zero) but fails on another one (returns > -ENOMEM). I asked you to have a look at the patches #1 and #2 of the > series > Link: https://lore.kernel.org/linux-nvme/20221007100134.faaekmuqyd5vy34m@mobilestation/ > and give your opinion whether the re-spin was required: take the > Keith' notes or keep the patches as is. Could you please clarify the > situation? I'll fix this patch up to follow the recommendation from Keith, I somehow thought this was already done.
