On 10/13/22 21:39, Naresh Kamboju wrote: > On Thu, 13 Oct 2022 at 12:41, Damien Le Moal > <damien.lemoal@xxxxxxxxxxxxxxxxxx> wrote: >> >> On 2022/10/12 16:24, Naresh Kamboju wrote: >>> On TI beagle board x15 the connected SSD is not detected on linux next >>> 20221006 tag. >>> >>> + export STORAGE_DEV=/dev/disk/by-id/ata-SanDisk_SSD_PLUS_120GB_190702A00D84 >>> + STORAGE_DEV=/dev/disk/by-id/ata-SanDisk_SSD_PLUS_120GB_190702A00D84 >>> + test -n /dev/disk/by-id/ata-SanDisk_SSD_PLUS_120GB_190702A00D84 >>> + echo y >>> + mkfs.ext4 /dev/disk/by-id/ata-SanDisk_SSD_PLUS_120GB_190702A00D84 >>> mke2fs 1.46.5 (30-Dec-2021) >>> The file /dev/disk/by-id/ata-SanDisk_SSD_PLUS_120GB_190702A00D84 does >>> not exist and no size was specified. >>> + lava-test-raise 'mkfs.ext4 >>> /dev/disk/by-id/ata-SanDisk_SSD_PLUS_120GB_190702A00D84 failed; job >>> exit' > > The reported issue is now noticed on the Linux mainline master branch. > > 1) > I see following config is missing on latest problematic builds > - CONFIG_HAVE_PATA_PLATFORM=y > > 2) > Following ahci sata kernel message are missing on problematic boots, > [ 1.408660] ahci 4a140000.sata: forcing port_map 0x0 -> 0x1 > [ 1.408691] ahci 4a140000.sata: AHCI 0001.0300 32 slots 1 ports 3 > Gbps 0x1 impl platform mode > [ 1.408721] ahci 4a140000.sata: flags: 64bit ncq sntf pm led clo > only pmp pio slum part ccc apst > [ 1.409820] scsi host0: ahci > [ 1.410064] ata1: SATA max UDMA/133 mmio [mem > 0x4a140000-0x4a1410ff] port 0x100 irq 98 The proper driver for this board is not being loaded I think, or not builtin. What is the compat string in the device tree for this ahci adapter ? What driver does it need ? I quickly tried to google that info but did not find any details. > 3) > GOOD: 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 > BAD: e08466a7c00733a501d3c5328d29ec974478d717 What are these ? "git show" says they are drm and rdma pull request merge from Linus... > 4) > Here i am adding links working and not working test jobs and kernel configs, > problematic test job: > - https://lkft.validation.linaro.org/scheduler/job/5641407#L2602 > Good test job: > - https://lkft.validation.linaro.org/scheduler/job/5640672#L2198 Hard to read... Can you send a diff of the kernel configs ? > 5) > metadata: > git_ref: master > git_repo: https://gitlab.com/Linaro/lkft/mirrors/torvalds/linux-mainline > git_sha: e08466a7c00733a501d3c5328d29ec974478d717 > git_describe: v6.0-7220-ge08466a7c007 > kernel_version: 6.0.0 > kernel-config: https://builds.tuxbuild.com/2Fourpiqf1OrlPFFtKwhHV0wAiq/config > build-url: https://gitlab.com/Linaro/lkft/mirrors/torvalds/linux-mainline/-/pipelines/661424896 > artifact-location: https://builds.tuxbuild.com/2Fourpiqf1OrlPFFtKwhHV0wAiq > toolchain: gcc-10 > > > 6) > For your information, > -- > I see diff on good to bad commits, > $ git log --oneline 9d84bb40bcb3..e08466a7c007 -- drivers/ata > 4078aa685097 Merge tag 'ata-6.1-rc1' of > git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata > 71d7b6e51ad3 ata: libata-eh: avoid needless hard reset when revalidating link > e3b1fff6c051 ata: libata: drop superfluous ata_eh_analyze_tf() parameter > b46c760e11c8 ata: libata: drop superfluous ata_eh_request_sense() parameter > cb6e73aaadff ata: libata-eh: Remove the unneeded result variable > ecf8322f464d ata: ahci_st: Enable compile test > 2d29dd108c78 ata: ahci_st: Fix compilation warning > 9628711aa649 ata: ahci-dwc: Add Baikal-T1 AHCI SATA interface support > bc7af9100fa8 ata: ahci-dwc: Add platform-specific quirks support > 33629d35090f ata: ahci: Add DWC AHCI SATA controller support > 6ce73f3a6fc0 ata: libahci_platform: Add function returning a clock-handle by id > 18ee7c49f75b ata: ahci: Introduce firmware-specific caps initialization > 7cbbfbe01a72 ata: ahci: Convert __ahci_port_base to accepting hpriv as arguments > fad64dc06579 ata: libahci: Don't read AHCI version twice in the > save-config method > 88589772e80c ata: libahci: Discard redundant force_port_map parameter > eb7cae0b6afd ata: libahci: Extend port-cmd flags set with port capabilities > f67f12ff57bc ata: libahci_platform: Introduce reset > assertion/deassertion methods > 3f74cd046fbe ata: libahci_platform: Parse ports-implemented property > in resources getter > 3c132ea6508b ata: libahci_platform: Sanity check the DT child nodes number > e28b3abf8020 ata: libahci_platform: Convert to using devm bulk clocks API > 82d437e6dcb1 ata: libahci_platform: Convert to using platform > devm-ioremap methods > d3243965f24a ata: make PATA_PLATFORM selectable only for suitable architectures > 3ebe59a54111 ata: clean up how architectures enable PATA_PLATFORM and > PATA_OF_PLATFORM > 55d5ba550535 ata: libata-core: Check errors in sata_print_link_status() > 03070458d700 ata: libata-sff: Fix double word in comments > 0b2436d3d25f ata: pata_macio: Remove unneeded word in comments > 024811a2da45 ata: libata-core: Simplify ata_dev_set_xfermode() > 066de3b9d93b ata: libata-core: Simplify ata_build_rw_tf() > e00923c59e68 ata: libata: Rename ATA_DFLAG_NCQ_PRIO_ENABLE > 614065aba704 ata: libata-core: remove redundant err_mask variable > fee6073051c3 ata: ahci: Do not check ACPI_FADT_LOW_POWER_S0 > 99ad3f9f829f ata: libata-core: improve parameter names for ata_dev_set_feature() > 16169fb78182 ata: libata-core: Print timeout value when internal command times I do not understand what you are trying to say here. These are the latest ata patches for 6.1. They touch different drivers and ata core. I still do not know which driver needs to be used on that board... >>> Test log: >>> - https://lkft.validation.linaro.org/scheduler/job/5634743#L2580 >>> >>> Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx> >>> >>> metadata: >>> git_ref: master >>> git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next >>> git_sha: 7da9fed0474b4cd46055dd92d55c42faf32c19ac >>> git_describe: next-20221006 >>> kernel_version: 6.0.0 >>> kernel-config: https://builds.tuxbuild.com/2FkkkZ51ZYhBL1G8D69YX8Pkt5F/config >>> build-url: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next/-/pipelines/659754170 >>> artifact-location: https://builds.tuxbuild.com/2FkkkZ51ZYhBL1G8D69YX8Pkt5F >>> toolchain: gcc-10 > > 7) >> The kernel messages that are shown in the links above do not show any "libata >> version 3.00 loaded." message nor any ata/ahci message that I can see. So I >> think the eSATA adapter is not even being detected and libata/ahci driver not used. >> >> Was this working before ? If yes, can you try with the following patches reverted ? >> >> d3243965f24a ("ata: make PATA_PLATFORM selectable only for suitable architectures") >> 3ebe59a54111 ("ata: clean up how architectures enable PATA_PLATFORM and >> PATA_OF_PLATFORM") > > I have reverted above two patches and but the problem has not been solved. OK. > > 8) >> If reverting these patches restores the eSATA port on this board, then you need >> to fix the defconfig for that board. > > OTOH, > Anders, enabled the new config CONFIG_AHCI_DWC=y and tried but the > device failed to boot. Why would you need to enable this new driver ? You board was working before without this new driver, so it is not the one to use for this board, right ? Please send the ata related bits of the device tree to understand what this board needs. -- Damien Le Moal Western Digital Research
