On 10/10/22 10:00, Chaitanya Kulkarni wrote: > Hi, > > The newly added helper blk_mq_init_alloc_tag_set() replaces existing > call to blk_mq_alloc_tag_set() and takes following arguments to > initialize tag_set before calling blk_mq_alloc_tag_set() :- > > * blk_mq_ops > * number of h/w queues > * queue depth > * driver data > > This approach is taken similar to what we have in the code where helper > function is added to alloc and initialize the common code that was > repeted in the callers :- > > * 8c16567d867ed 5 args-init and alloc helper bio_alloc_bioset() > * 0a3140ea0fae3 5 args-init and alloc helper blk_next_bio() > * cdb14e0f7775e 4 args-init and alloc helper blk_mq_alloc_sq_tag_set() > > With 5 arguments it shuold be easy to review and we don't have to extend > the API even if tag_set gets a new member, I'll gradually change the > drivers slowly to avoid one big treewide change. > > This avoids code repetation of inialization code of tag set in current > block drivers and any future ones. > Please ignore this this has a bug, I'll send it with bug fixed. Apologies for the noise. -ck
