Re: [RFC PATCH 01/21] block: add and use init tagset helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/6/22 11:13, Chaitanya Kulkarni wrote:
I will trim down the argument list with the most common arguments
and keep it to max 4-5 mandatory arguments identical to what we
have done this for blk_next_bio() and bio_alloc_bioset() [1]
where mandatory arguments are part of the initialization API
than repeating the code all the in the tree, that creates
maintenance work of treewide patches.

Also, instead of doing tree wide change in series I'll start small
and gradually add more patches over time.

This definitely adds a more value to the code where code is not
repeated for mandatory arguments, which are way less than 9.

Hmm ... I'm not convinced that the approach outlined above will result
in a valuable patch series. I think my objections also apply to the
approach outlined above.

Bart.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux