On Fri, Sep 30, 2022 at 01:46:46AM +0300, Serge Semin wrote: > Inability to allocate a buffer is a critical error which shouldn't be > tolerated since most likely the rest of the driver won't work correctly. > Thus instead of returning the zero status let's return the -ENOMEM error > if the nvme_hwmon_data structure instance couldn't be created. Nak for this one. The hwmon is not necessary for the rest of the driver to function, so having the driver detach from the device seems a bit harsh. The driver can participate in memory reclaim, so failing on a low memory condition can make matters worse. The rest looks good, though. > @@ -230,7 +230,7 @@ int nvme_hwmon_init(struct nvme_ctrl *ctrl) > > data = kzalloc(sizeof(*data), GFP_KERNEL); > if (!data) > - return 0; > + return -ENOMEM; > > data->ctrl = ctrl; > mutex_init(&data->read_lock); > --
