On 2022-09-29 08:56, Christoph Hellwig wrote: > On Thu, Sep 29, 2022 at 08:24:25AM +0200, Pankaj Raghav wrote: >> Use blk_mq_plug() wrapper to get the plug instead of directly accessing >> it in the block layer. > > I think this should explain why that is useful (or maybe even a bug > fix?). I mentioned it in the commit header: to use this wrapper consistently across block layer because I am not sure if either of the changes would have led to a bug in zoned devices. 1) blk_execute_rq_nowait: No issues here because only passthrough request can use this function. 2) calling blk_flush_plug in bio_poll: As we don't plug the request that do a write or write zeroes to zoned devices in the first place, flushing should not have any impact. This is just a cleanup patch to use this helper consistently. Maybe I should mention it explicitly again in the commit log to make it clear? -- Pankaj
