>>> There is a parallel work going on to support non-po2 zone sizes in Linux >>> block layer and drivers[1]. I don't see any reason why we shouldn't make >>> the calculations generic here instead of putting the constraint on zone >>> sectors to be po2 as the virtio spec also supports it. >> >> That series is not upstream, so implementing against would not be the >> correct approach, especially given that this would also impact qemu code. >> > > I am aware about the effort to support non-^2 zone sizes in the kernel and this > activity actually made me drop the ^2 zone size requirement from the virtio-zbd > specification. I think that the best way to add non-^2 zone size support to this > driver could be a follow up patch to this series. This way, we won't rely on the > code that is not yet merged upstream. > It is actually not relying on the code that is not merged upstream but rather future proofing the code with generic calculations that will not have any performance impact. But if you don't want to pick up these changes now, I can do it in the future as well as the changes are trivial. -- Pankaj
