Re: [PATCH v2 3/3] blk-wbt: don't enable throttling if default elevator is bfq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yu Kuai <yukuai1@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 3/3] blk-wbt: don't enable throttling if default elevator is bfq
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 20 Sep 2022 00:25:53 -0700
Cc: paolo.valente@xxxxxxxxxx, axboe@xxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, yukuai3@xxxxxxxxxx, yi.zhang@xxxxxxxxxx
In-reply-to: <20220919070916.2738443-4-yukuai1@huaweicloud.com>
References: <20220919070916.2738443-1-yukuai1@huaweicloud.com> <20220919070916.2738443-4-yukuai1@huaweicloud.com>

Matching names is always is a bad idea.

Just ad a flags field to elevator_mq_ops, add a DISABLE_WBT flag
to it, and check for that and everything should become much, much
simpler.

Follow-Ups:
- Re: [PATCH v2 3/3] blk-wbt: don't enable throttling if default elevator is bfq
  - From: Yu Kuai

References:
- [PATCH v2 0/3] blk-wbt: simple improvment to enable wbt correctly
  - From: Yu Kuai
- [PATCH v2 3/3] blk-wbt: don't enable throttling if default elevator is bfq
  - From: Yu Kuai

Prev by Date: Re: [PATCH v9 7/8] PCI/P2PDMA: Allow userspace VMA allocations through sysfs
Next by Date: Re: [PATCH 1/4] brd: make brd_insert_page return bool
Previous by thread: [PATCH v2 3/3] blk-wbt: don't enable throttling if default elevator is bfq
Next by thread: Re: [PATCH v2 3/3] blk-wbt: don't enable throttling if default elevator is bfq
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux