Hi,
在 2022/09/19 12:28, kernel test robot 写道:
Hi Yu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20220916]
url: https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/blk-wbt-simple-improvment-to-enable-wbt-correctly/20220919-094019
base: d5538ab91d3a9a237805be6f8c6c272af2987995
config: parisc-randconfig-r021-20220919 (https://download.01.org/0day-ci/archive/20220919/202209191232.Nwt56uMD-lkp@xxxxxxxxx/config)
compiler: hppa-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/dd5a7be692b8fc9794f29648d0805a2d65b9c4de
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Yu-Kuai/blk-wbt-simple-improvment-to-enable-wbt-correctly/20220919-094019
git checkout dd5a7be692b8fc9794f29648d0805a2d65b9c4de
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
block/blk-sysfs.c: In function 'queue_wb_lat_show':
block/blk-sysfs.c:475:15: error: implicit declaration of function 'wbt_disabled'; did you mean 'irqs_disabled'? [-Werror=implicit-function-declaration]
475 | lat = wbt_disabled(q) ? 0 : div_u64(wbt_get_min_lat(q), 1000);
| ^~~~~~~~~~~~
| irqs_disabled
cc1: some warnings being treated as errors
I forgot to provide a definition while config is disabled, I'll send a
new version to fix this.
Thanks,
Kuai
vim +475 block/blk-sysfs.c
467
468 static ssize_t queue_wb_lat_show(struct request_queue *q, char *page)
469 {
470 u64 lat;
471
472 if (!wbt_rq_qos(q))
473 return -EINVAL;
474
> 475 lat = wbt_disabled(q) ? 0 : div_u64(wbt_get_min_lat(q), 1000);
476
477 return sprintf(page, "%llu\n", lat);
478 }
479
