Re: [PATCH for-next v5 4/4] nvme: wire up fixed buffer support for nvme passthrough

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>   	req = nvme_alloc_user_request(q, cmd, ubuffer, bufflen, meta_buffer,
> -			meta_len, meta_seed, &meta, timeout, vec, 0, 0);
> +			meta_len, meta_seed, &meta, timeout, vec, 0, 0, NULL, 0);
>   	if (IS_ERR(req))
>   		return PTR_ERR(req);

14 Arguments to the function!

Kanchan, I'm not pointing out to this patch it has happened over
the years, I think it is high time we find a way to trim this
down.

Least we can do is to pass a structure member than 14 different
arguments, is everyone okay with it ?

-ck





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux