On Mon, Sep 05, 2022 at 01:15:16PM +0000, Johannes Thumshirn wrote: > On 01.09.22 09:43, Christoph Hellwig wrote: > > + ASSERT(btrfs_dev_is_sequential(dev, physical)); > > + bio->bi_iter.bi_sector = zone_start >> SECTOR_SHIFT; > > That ASSERT() will trigger on conventional zones, won't it? The assert is inside a if (bio_op(bio) == REQ_OP_ZONE_APPEND) { btrfs_submit_chunk only sets the op to REQ_OP_ZONE_APPEND when btrfs_use_zone_append returns true, which excludes conventional zones.