Re: [PATCH] blk-mq: determine in advance whether batch alloc can be performed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2022/8/26 21:33, Jens Axboe wrote:
On 8/25/22 7:26 PM, Liu Song wrote:
From: Liu Song <liusong@xxxxxxxxxxxxxxxxx>

Some conditions for judging whether batch alloc can be performed are
included in "blk_mq_get_tags", and this function is only used by
"__blk_mq_alloc_requests_batch".

This patch introduced a helper "can_do_batch_alloc" to prepend the
judgment condition and avoid unnecessary function calls.
Curious if you saw any differences from this? Or do you just consider
it a cleanup?

Hi

This patch aggregates the judgment conditions for whether batch alloc can be used,
which can be considered as clean up.

If it can be determined at the first judgment that batch alloc cannot be used, the overhead of calling "blk_mq_get_tags" once will be reduced, are some differences.


Thanks




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux