Re: [PATCH v11 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Damien,
>> + */
>> +static bool bio_in_emulated_zone_area(struct dm_po2z_target *dmh,
>> +				      struct bio *bio, int *offset)
> 
> This function name reads like it is a block layer helper. It mat be less
> confucing to keep using the dm_po2z_ prefix for it.
>
Good point. Even though it is a static function in the same file, it could
be confused for a block helper at the caller site.
>> +{
>> +	/*
>> +	 * Read operation on the emulated zone area (between zone capacity
>> +	 * and zone size) will fill the bio with zeroes. Any other operation

>> +
>> +	return DM_MAPIO_KILL;
>> +}
> 
Do you see any more issues apart from the two you pointed out?



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux