Hi, Tejun!
在 2022/08/17 4:14, Tejun Heo 写道:
On Tue, Aug 02, 2022 at 10:04:15PM +0800, Yu Kuai wrote:
From: Yu Kuai <yukuai3@xxxxxxxxxx>
All related operations are inside 'queue_lock', there is no need to use
the flag, we only need to make sure throtl_enqueue_tg() is called when
the first bio is throttled, and throtl_dequeue_tg() is called when the
last throttled bio is dispatched. There are no functional changes in
this patch.
I don't know whether this is better or not. It's minutely less lines of code
but also makes the code a bit more fragile. I'm ambivalent. At any rate,
please move these trivial patches to the head of the series or post them
separately.
Can I ask why do you think this patch makes the code a bit more fragile?
By the way, I'll post these trivial patches separately.
Thanks,
Kuai
Thanks.