On Mon, Aug 15, 2022 at 10:36:32AM +0800, ZiyangZhang wrote: > Since __ublk_rq_task_work always fails requests immediately during > exiting, __ublk_fail_req() is only called from abort context during > exiting. So lock is unnecessary. > > Signed-off-by: ZiyangZhang <ZiyangZhang@xxxxxxxxxxxxxxxxx> > --- > drivers/block/ublk_drv.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c > index 17896172b0fe..685a43b7ae6e 100644 > --- a/drivers/block/ublk_drv.c > +++ b/drivers/block/ublk_drv.c > @@ -605,8 +605,9 @@ static void ublk_complete_rq(struct request *req) > } > > /* > - * __ublk_fail_req() may be called from abort context or ->ubq_daemon > - * context during exiting, so lock is required. > + * Since __ublk_rq_task_work always fails requests immediately during > + * exiting, __ublk_fail_req() is only called from abort context during > + * exiting. So lock is unnecessary. > * > * Also aborting may not be started yet, keep in mind that one failed > * request may be issued by block layer again. > -- > 2.27.0 > Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx> -- Ming
