On Wed, Aug 10, 2022 at 12:05:05PM -0600, Keith Busch wrote: > The functions are implemented under 'include/linux/', indistinguishable from > exported APIs. I think I understand why they are there, but they look the same > as exported functions from a driver perspective. swiotlb.h is not a driver API. There's two leftovers used by the drm code I'm trying to get fixed up, but in general the DMA API is the interface and swiotlb is just an implementation detail. > Perhaps I'm being daft, but I'm totally missing why I should care if swiotlb > leverages this feature. If you're using that, you've traded performance for > security or compatibility already. If this idea can be used to make it perform > better, then great, but that shouldn't be the reason to hold this up IMO. We firstly need to make sure that everything actually works on swiotlb, or any other implementation that properly implements the DMA API. And the fact that I/O performance currently sucks and we can fix it on the trusted hypervisor is an important consideration. At least as importantant as micro-optimizing performance a little more on setups not using them. So not taking care of both in one go seems rather silly for a feature that is in its current form pretty intrusive and thus needs a really good justification. > This optimization needs to be easy to reach if we expect anyone to use it. > Working with arbitrary user addresses with minimal additions to the user ABI > was deliberate. If you want a special allocator, we can always add one later; > this series doesn't affect that. > > If this has potential to starve system resource though, I can constrain it to > specific users like CAP_SYS_ADMIN, or maybe only memory allocated from > hugetlbfs. Or perhaps a more complicated scheme of shuffling dma mapping > resources on demand if that is an improvement over the status quo. Or just not bother with it at all. Because with all those limits it really does not seems to be worth to an entirely need type of bio payload to the block layer and a lot of boilerplate to drivers.
