On Wed, Aug 03, 2022 at 10:42:32AM -0700, Linus Torvalds wrote: > Warnings are fatal. Deal with it. If you think it's ok to have > warnings in your code, go do another project. Please stop this BS. I'm the first one to fix every single warning reported, because I absoutely want warning free code to see problems. But that does not mean it is "fatal". It is bad and should go away by either fixing the code, or if the warning is too broken disable it in the compiler. But that does not in any way mean code that creates warning on some compilers is completely untested and by definition broken. We've fixed the warning the day it was reported because of just that, and we'd always do. But that doesn't make it whole giant drama. > The fact is, apparently -Werror _did_ find it, and the people involved There is nothing about Werror breaking it. The buildbot reported it, and that usually reports warnings and errors, so it did not make any difference. > I want whatever went wrong in that process fixed. Why did you make a > pull request to Jens, and then never notified him about the problems > in it? Because so far we've never made a big fuzz about a configuation so obscrube that it takes build bot more than a week to find it. We just fix it and go on with life. But now that I see that you somehow see it a personal insult I'll be more careful about it. But to be honest, while I agree with you 100% that code should be warning free I'm really amazed about all the drama this created.
