On Fri, Jul 29, 2022 at 04:24:31PM +0200, Christoph Hellwig wrote: > On Fri, Jul 29, 2022 at 03:29:54PM +0800, Ming Lei wrote: > > Remove all block device related info from ublksrv_ctrl_dev_info, > > meantime reduce its size into 64 bytes because: > > > > 1) ublksrv_ctrl_dev_info becomes cleaner without including any > > block related info > > > > 2) generic set/get parameter command can be used to set block > > related setting easily and cleanly > > > > 3) generic set/get parameter command can be used for extending > > ublk without needing more info in ublksrv_ctrl_dev_info > > This should condense the structure instead of spreading random > reserveѕ. > > One more reason why we should not just merge half-baked UAPIs before > a few good rounds of review :( This patch does depend on set/get parameter(s) command. Thanks, Ming
