On Jul 28, 2022 / 16:46, Christoph Hellwig wrote: > On Wed, Jul 27, 2022 at 05:52:47PM +0900, Shin'ichiro Kawasaki wrote: > > After the commit "common/rc: avoid module load in _have_driver()", > > _have_driver() no longer loads specified module. However, nbd test cases > > and _have_nbd_netlink() function assume that the module is loaded by > > calling _have_driver(). This causes test case failures and unexpected > > skips. To fix them, load and unload modules explicitly in functions > > _start_nbd_server*(), _stop_nbd_server*() and _have_nbd_netlink(). > > Did you test this with built-in nbd? Yes. I confirmed all test cases in nbd test group pass with built-in nbd. The modprobe command with -q option does nothing for built-in drivers. When I confirmed that, I found even nbd/004 passes, which should be skipped. Next patch addresses this issue. -- Shin'ichiro Kawasaki
