On 2022/7/26 15:39, Ming Lei wrote:
On Tue, Jul 26, 2022 at 01:01:41PM +0800, Yufen Yu wrote:
hi Ming,
Here rq2 fail from blk_mq_plug_issue_direct() in blk_mq_flush_plug_list(),
not blk_mq_sched_insert_requests
OK, just wondering why Yufen's patch touches
blk_mq_sched_insert_requests().
Here the issue is in blk_mq_plug_issue_direct() itself, it is wrong to use last
request of plug list to decide if run queue is needed since all the remained
requests in plug list may be from other hctxs, and the simplest fix could be pass
run_queue as true always to blk_mq_request_bypass_insert().
OK, thanks for your suggestion and I will send v2.
Thanks,
Yufen
Thanks,
Ming
.
