On Fri, Jul 22, 2022 at 11:53:19AM +0200, Christoph Hellwig wrote: > On Fri, Jul 22, 2022 at 04:45:16PM +0800, Ming Lei wrote: > > /* We are not ready to support zero copy */ > > + ub->dev_info.flags &= ~UBLK_F_SUPPORT_ZERO_COPY; > > Nit: I'd move this below the clearing of UBLK_F_ALL. Not because it > makes much of a differece, but because it flows more logical. OK. > > > +/* All UBLK_F_* have to be included into UBLK_F_ALL */ > > +#define UBLK_F_ALL (UBLK_F_SUPPORT_ZERO_COPY | UBLK_F_URING_CMD_COMP_IN_TASK) > > And this should not be in the uapi header but only kernel internal. Yeah, but that may cause UBLK_F_ALL not updated easily, :-( Thanks, Ming
