> Il giorno 6 lug 2022, alle ore 07:35, Yu Zhe <yuzhe@xxxxxxxxxxxx> ha scritto:
>
> remove unnecessary void* type castings.
>
Thanks for improving BFQ code. Which commit made these casts unnecessary?
Paolo
> Signed-off-by: Yu Zhe <yuzhe@xxxxxxxxxxxx>
> ---
> block/bfq-wf2q.c | 6 +++---
> block/blk-iocost.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
> index f8eb340381cf..2a666b100bcb 100644
> --- a/block/bfq-wf2q.c
> +++ b/block/bfq-wf2q.c
> @@ -474,7 +474,7 @@ static void bfq_active_insert(struct bfq_service_tree *st,
> #ifdef CONFIG_BFQ_GROUP_IOSCHED
> sd = entity->sched_data;
> bfqg = container_of(sd, struct bfq_group, sched_data);
> - bfqd = (struct bfq_data *)bfqg->bfqd;
> + bfqd = bfqg->bfqd;
> #endif
> if (bfqq)
> list_add(&bfqq->bfqq_list, &bfqq->bfqd->active_list);
> @@ -573,7 +573,7 @@ static void bfq_active_extract(struct bfq_service_tree *st,
> #ifdef CONFIG_BFQ_GROUP_IOSCHED
> sd = entity->sched_data;
> bfqg = container_of(sd, struct bfq_group, sched_data);
> - bfqd = (struct bfq_data *)bfqg->bfqd;
> + bfqd = bfqg->bfqd;
> #endif
> if (bfqq)
> list_del(&bfqq->bfqq_list);
> @@ -719,7 +719,7 @@ __bfq_entity_update_weight_prio(struct bfq_service_tree *old_st,
> else {
> sd = entity->my_sched_data;
> bfqg = container_of(sd, struct bfq_group, sched_data);
> - bfqd = (struct bfq_data *)bfqg->bfqd;
> + bfqd = bfqg->bfqd;
> }
> #endif
>
> diff --git a/block/blk-iocost.c b/block/blk-iocost.c
> index 33a11ba971ea..117181a69b7a 100644
> --- a/block/blk-iocost.c
> +++ b/block/blk-iocost.c
> @@ -1430,7 +1430,7 @@ static int iocg_wake_fn(struct wait_queue_entry *wq_entry, unsigned mode,
> int flags, void *key)
> {
> struct iocg_wait *wait = container_of(wq_entry, struct iocg_wait, wait);
> - struct iocg_wake_ctx *ctx = (struct iocg_wake_ctx *)key;
> + struct iocg_wake_ctx *ctx = key;
> u64 cost = abs_cost_to_cost(wait->abs_cost, ctx->hw_inuse);
>
> ctx->vbudget -= cost;
> --
> 2.11.0
>
