On Mon, Jul 18, 2022 at 04:01:53PM -0500, gjoyce@xxxxxxxxxxxxxxxxxx wrote:
> + if (discv_out) {
> + buf_out = (u8 __user *)(uintptr_t)discv_out->data;
> + len_out = min(discv_out->size, (u64)hlen);
> + if (buf_out && copy_to_user(buf_out, dev->resp, len_out)) {
> + return -EFAULT;
> + }
No need for the braces here.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
