Re: [PATCH v2 00/63] Improve static type checking for request flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/13/22 3:48 PM, Bart Van Assche wrote:
> On 6/29/22 16:30, Bart Van Assche wrote:
>> A source of confusion in the block layer is that can be nontrivial to determine
>> which type of flags a u32 function argument accepts. This patch series clears
>> up that confusion for request flags by introducing a new __bitwise type, namely
>> blk_opf_t. Additionally, the type 'int' is change into 'enum req_op' where used
>> to hold a request operation.
>>
>> Analysis of the sparse warnings introduced by this conversion resulted in one
>> bug fix ("blktrace: Trace remap operations correctly").
>>
>> Although the number of patches in this series is significant, the risk of this
>> patch series is low since most patches involve changing one integer type (int
>> or u32) into another integer type of the same size (enum req_op or blk_opf_t).
>>
>> Please consider this patch series for kernel v5.20.
> 
> (replying to my own email)
> 
> Hi Jens,
> 
> I think that everyone who is interested in reviewing this patch series
> has had sufficient time to review the patches in this patch series. Do
> you prefer to queue this patch series for kernel v5.20 or kernel
> v5.21?

I've been pondering the same. I'm fine with going for 5.20 as this will
be a pain to maintain, but the first patch doesn't even apply to my
for-5.20/block branch...

-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux