Re: [PATCH 01/17] block: remove a superflous ifdef in blkdev.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04.07.22 15:02, Christoph Hellwig wrote:
> On Mon, Jul 04, 2022 at 12:58:40PM +0000, Johannes Thumshirn wrote:
>>> -#ifdef CONFIG_BLK_DEV_ZONED
>>> -
>>>  /* Helper to convert BLK_ZONE_ZONE_XXX to its string format XXX */
>>>  const char *blk_zone_cond_str(enum blk_zone_cond zone_cond);
>>>  
>>
>> Won't this break tracing in null_blk, which uses blk_zone_cond_str()?
> 
> How could removing an ifdef and exposing a prototype unconditionally
> in a header break tracing?
> 

*facepalm* the trace code doesn't get compiled without CONFIG_BLK_DEV_ZONED.
My bad.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux