On 04.07.22 15:02, Christoph Hellwig wrote: > On Mon, Jul 04, 2022 at 12:58:40PM +0000, Johannes Thumshirn wrote: >>> -#ifdef CONFIG_BLK_DEV_ZONED >>> - >>> /* Helper to convert BLK_ZONE_ZONE_XXX to its string format XXX */ >>> const char *blk_zone_cond_str(enum blk_zone_cond zone_cond); >>> >> >> Won't this break tracing in null_blk, which uses blk_zone_cond_str()? > > How could removing an ifdef and exposing a prototype unconditionally > in a header break tracing? > *facepalm* the trace code doesn't get compiled without CONFIG_BLK_DEV_ZONED. My bad. Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
