Re: [PATCH v2 63/63] fs/zonefs: Use the enum req_op type for request operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/30/22 08:31, Bart Van Assche wrote:
> Cc: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
> Cc: Naohiro Aota <naohiro.aota@xxxxxxx>
> Cc: Johannes Thumshirn <jth@xxxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
>  fs/zonefs/trace.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/zonefs/trace.h b/fs/zonefs/trace.h
> index 21501da764bd..42edcfd393ed 100644
> --- a/fs/zonefs/trace.h
> +++ b/fs/zonefs/trace.h
> @@ -25,7 +25,7 @@ TRACE_EVENT(zonefs_zone_mgmt,
>  	    TP_STRUCT__entry(
>  			     __field(dev_t, dev)
>  			     __field(ino_t, ino)
> -			     __field(int, op)
> +			     __field(enum req_op, op)
>  			     __field(sector_t, sector)
>  			     __field(sector_t, nr_sectors)
>  	    ),

Nit: the patch title could be more to the point, E.g.

fs/zonefs: Use the enum req_op type for zone operation trace events

Otherwise, looks good.

Acked-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>

-- 
Damien Le Moal
Western Digital Research



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux