From: Bart Van Assche <bvanassche@xxxxxxx>
> Trace the remapped operation and its flags instead of only the data
> direction of remapped operations. This issue was detected by analyzing
> the warnings reported by sparse related to the new blk_opf_t type.
>
> Cc: Mike Snitzer <snitzer@xxxxxxxxxx>
> Cc: Jun'ichi Nomura <junichi.nomura@xxxxxxx>
> Fixes: b0da3f0dada7 ("Add a tracepoint for block request remapping")
..
> __blk_add_trace(bt, blk_rq_pos(rq), blk_rq_bytes(rq),
> - rq_data_dir(rq), 0, BLK_TA_REMAP, 0,
> + req_op(rq), rq->cmd_flags, BLK_TA_REMAP, 0,
> sizeof(r), &r, blk_trace_request_get_cgid(rq));
Thank you. I think the change is fine but what it really fixes is
1b9a9ab78b0a ("blktrace: use op accessors"), where arguments of
__blk_add_trace() was extended.
--
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
