On Wed, Jun 29, 2022 at 12:37:59PM -0700, Bart Van Assche wrote: > On 6/29/22 12:05, Kent Overstreet wrote: > > On Wed, Jun 29, 2022 at 11:51:27AM -0700, Bart Van Assche wrote: > > > On 6/29/22 11:40, Kent Overstreet wrote: > > > > But Jens, to be blunt - I know we have different priorities in the way we write code. > > > > > > Please stay professional in your communication and focus on the technical > > > issues instead of on the people involved. > > > > > > BTW, I remember that some time ago I bisected a kernel bug to one of your > > > commits and that you refused to fix the bug introduced by that commit. I had > > > to spend my time on root-causing it and sending a fix upstream. > > > > I'd be genuinely appreciative if you'd refresh my memory on what it was. Because > > yeah, if I did that that was my fuckup and I want to learn from my mistakes. > > I was referring to the following two conversations from May 2018: > * [PATCH] Revert "block: Add warning for bi_next not NULL in bio_endio()" (https://lore.kernel.org/linux-block/20180522235505.20937-1-bart.vanassche@xxxxxxx/) > * [PATCH v2] Revert "block: Add warning for bi_next not NULL in bio_endio()" (https://lore.kernel.org/linux-block/20180619172640.15246-1-bart.vanassche@xxxxxxx/) And also, why did you decide to just revert instead of fixing the issue within DM? You had a WARN() printed, you shouldn't have needed to bisect, the commit message explained what was going on - but you never explained that part?