On Wed, Jun 29, 2022 at 09:50:21AM +0800, Jason Yan wrote: > +static void blkcg_iostat_update(struct blkcg_gq *blkg, > + struct blkg_iostat *cur, struct blkg_iostat *last) Incorrect indentation. Continuing prototype lines are indented either using two tabs or after the opening brace. The rest looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>