On 6/28/22 8:49 AM, Jason Yan wrote:
> To reduce some duplicated code, factor out blkcg_iostat_update(). No
> functional change.
>
> Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> ---
> block/blk-cgroup.c | 37 ++++++++++++++++++++-----------------
> 1 file changed, 20 insertions(+), 17 deletions(-)
>
> diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
> index 764e740b0c0f..60d205ec213e 100644
> --- a/block/blk-cgroup.c
> +++ b/block/blk-cgroup.c
> @@ -846,6 +846,21 @@ static void blkg_iostat_sub(struct blkg_iostat *dst, struct blkg_iostat *src)
> }
> }
>
> +static inline void blkcg_iostat_update(struct blkcg_gq *blkg,
> + struct blkg_iostat *cur, struct blkg_iostat *last)
> +{
> + struct blkg_iostat delta;
> + unsigned long flags;
> +
> + /* propagate percpu delta to global */
> + flags = u64_stats_update_begin_irqsave(&blkg->iostat.sync);
> + blkg_iostat_set(&delta, cur);
> + blkg_iostat_sub(&delta, last);
> + blkg_iostat_add(&blkg->iostat.cur, &delta);
> + blkg_iostat_add(last, &delta);
> + u64_stats_update_end_irqrestore(&blkg->iostat.sync, flags);
> +}
> +
Please kill the inline.
--
Jens Axboe
