Hi Xiao, thanks for this action! On Jun 26, 2022 / 22:24, Xiao Yang wrote: > Split _have_kernel_option() into _have_kernel_config_file() > and _check_kernel_option(). > 1) _have_kernel_config_file() will set SKIP_REASON when neither > /boot/config* nor /proc/config.gz is available. > 2) _check_kernel_option() will not set SKIP_RESAON when the specified > kernel option is not defined. > > Signed-off-by: Xiao Yang <yangx.jy@xxxxxxxxxxx> It's the better to keep _have_kernel_option() isn't it? It will make this patch smaller since many of existing _have_kernel_option() calls can be left as is. _have_kernel_option() can be rewritten to call _have_kernel_config_file() and _check_kernel_option(). To distinguish usages of _have_kernel_option() and _check_kernel_option(), short comments on those functions will be helpful. -- Shin'ichiro Kawasaki
