Re: [PATCH 51/51] fs/zonefs: Fix sparse warnings in tracing code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/23/22 21:56, Christoph Hellwig wrote:
On Thu, Jun 23, 2022 at 11:05:28AM -0700, Bart Van Assche wrote:
Since __bitwise types are not supported by the tracing infrastructure, store
the operation type as an int in the tracing event.

Please give the field in the trace even the proper type instead of
all the crazy casting.

Hi Christoph,

I will do that. BTW, I discovered the code in the tracing infrastructure that makes sparse unhappy:

#define is_signed_type(type) (((type)(-1)) < (type)1)

Sparse reports four warnings for that expression if 'type' is a bitwise type. Two of these warnings can be suppressed by changing 'type' into '__force type'. I have not yet found a way to suppress all the sparse warnings triggered by the is_signed_type() macro for bitwise types.

Thanks,

Bart.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux