On 6/23/22 17:19, Damien Le Moal wrote:
On 6/24/22 08:26, Bart Van Assche wrote:+static inline bool blk_queue_pipeline_zoned_writes(struct request_queue *q) +{ + return test_bit(QUEUE_FLAG_PIPELINE_ZONED_WRITES, &(q)->queue_flags); +} +Since this flag will be set by an LLD to indicate that the LLD can handle zoned write commands in order, I would suggest a different name. Something like: QUEUE_FLAG_ORDERED_ZONED_WRITES ? And well, if the LLD says it can do that for zoned writes, it likely means that it would be the same for any command, so the flag could be generalized and named QUEUE_FLAG_ORDERED_CMD or something like that.
Zoned writes should always be submitted in order by the software that generates the zoned writes so I think the name QUEUE_FLAG_ORDERED_ZONED_WRITES would cause confusion. I'm concerned it would make other kernel developers wonder whether it is OK for e.g. filesystems to submit zoned writes out of order, which is not the case. I think the word "pipelining" has a well-established meaning in computer science and also that in this context it reflects the intent correctly. See also https://en.wikipedia.org/wiki/Pipeline_(computing).
Thanks, Bart.
