On Jun 24, 2022 / 15:50, Xiao Yang wrote:
> In _have_kernel_option(), SKIP_REASON = "kernel option NVME_MULTIPATH > has not been enabled" is expected but all nvmeof-mp tests are
skipped > due to the SKIP_REASON. For example: >
----------------------------------------------------- > ./check
nvmeof-mp/001 > nvmeof-mp/*** [not run] > kernel option NVME_MULTIPATH
has not been enabled >
----------------------------------------------------- > > Avoid the
issue by unsetting the SKIP_REASON. > > Signed-off-by: Xiao Yang
<yangx.jy@xxxxxxxxxxx>
Good catch. Thanks!
This issue was triggered by the commit 7ae143852f6c ("common/rc: don't unset
previous SKIP_REASON in _have_kernel_option()"). So let's add a "Fixes" tag to
note it.
> --- > tests/nvmeof-mp/rc | 5 +++++ > 1 file changed, 5 insertions(+) > >
diff --git a/tests/nvmeof-mp/rc b/tests/nvmeof-mp/rc > index
dcb2e3c..9c91f8c 100755 > --- a/tests/nvmeof-mp/rc > +++
b/tests/nvmeof-mp/rc > @@ -24,6 +24,11 @@ and multipathing has been
enabled in the nvme_core kernel module" > return > fi > > + # In
_have_kernel_option(), SKIP_REASON = "kernel option > + #
NVME_MULTIPATH has not been enabled" is expected so > + # avoid
skipping tests by unsetting the SKIP_REASON
Can we have shorter comment? Like:
# Avoid test skip due to SKIP_REASON set by _have_kernel_option().
> + unset SKIP_REASON
Well, IMO it's not always correct to unsetSKIP_REASON, for example, if
the OS didn't have kernel config file, we should report the test as 'not
run'
Thanks
Zhijian
> +
The change above looks good to me, and I confirmed it fixies the issue.
--
Shin'ichiro Kawasaki
