On 6/24/22 2:05 AM, Bart Van Assche wrote:
> Improve static type checking by using the enum req_op type for variables
> that represent a request operation and the new blk_opf_t type for
> variables that represent request flags.
>
> Cc: Mark Fasheh <mark@xxxxxxxxxx>
> Cc: Joel Becker <jlbec@xxxxxxxxxxxx>
> Cc: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
Looks fine to me.
Acked-by: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>
> ---
> fs/ocfs2/cluster/heartbeat.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
> index ea0e70c0fce0..e955aca87936 100644
> --- a/fs/ocfs2/cluster/heartbeat.c
> +++ b/fs/ocfs2/cluster/heartbeat.c
> @@ -503,8 +503,8 @@ static void o2hb_bio_end_io(struct bio *bio)
> static struct bio *o2hb_setup_one_bio(struct o2hb_region *reg,
> struct o2hb_bio_wait_ctxt *wc,
> unsigned int *current_slot,
> - unsigned int max_slots, int op,
> - int op_flags)
> + unsigned int max_slots, enum req_op op,
> + blk_opf_t op_flags)
> {
> int len, current_page;
> unsigned int vec_len, vec_start;
