On 6/24/22 03:05, Bart Van Assche wrote:
> Since __bitwise types are not supported by the tracing infrastructure, store
> the operation type as an int in the tracing event.
>
> Cc: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
> Cc: Naohiro Aota <naohiro.aota@xxxxxxx>
> Cc: Johannes Thumshirn <jth@xxxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> fs/zonefs/trace.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/zonefs/trace.h b/fs/zonefs/trace.h
> index 21501da764bd..8707e1c3023c 100644
> --- a/fs/zonefs/trace.h
> +++ b/fs/zonefs/trace.h
> @@ -32,15 +32,15 @@ TRACE_EVENT(zonefs_zone_mgmt,
> TP_fast_assign(
> __entry->dev = inode->i_sb->s_dev;
> __entry->ino = inode->i_ino;
> - __entry->op = op;
> + __entry->op = (__force int)op;
> __entry->sector = ZONEFS_I(inode)->i_zsector;
> __entry->nr_sectors =
> ZONEFS_I(inode)->i_zone_size >> SECTOR_SHIFT;
> ),
> TP_printk("bdev=(%d,%d), ino=%lu op=%s, sector=%llu, nr_sectors=%llu",
> show_dev(__entry->dev), (unsigned long)__entry->ino,
> - blk_op_str(__entry->op), __entry->sector,
> - __entry->nr_sectors
> + blk_op_str((__force enum req_op)__entry->op),
> + __entry->sector, __entry->nr_sectors
> )
> );
>
How do you get the warning ? I always run sparse and have not seen any
warning... Looks good anyway, will apply.
--
Damien Le Moal
Western Digital Research
