On Tue 21-06-22 09:00:57, Damien Le Moal wrote:
> On 6/21/22 01:11, Jan Kara wrote:
> > @@ -2790,6 +2791,11 @@ static inline struct request *blk_mq_get_cached_request(struct request_queue *q,
> > return rq;
> > }
> >
> > +static void bio_set_ioprio(struct bio *bio)
> > +{
> > + blkcg_set_ioprio(bio);
> > +}
>
> Nit: Make this inline ?
Similar response as to the other static function you wanted to make inline.
I'm pretty sure it will get inlined regardless of whether I write there
inline or not so I prefer not to clutter the declaration :).
> > +
> > /**
> > * blk_mq_submit_bio - Create and send a request to block device.
> > * @bio: Bio pointer.
> > @@ -2830,6 +2836,8 @@ void blk_mq_submit_bio(struct bio *bio)
> >
> > trace_block_getrq(bio);
> >
> > + bio_set_ioprio(bio);
> > +
> > rq_qos_track(q, rq, bio);
> >
> > blk_mq_bio_to_request(rq, bio, nr_segs);
>
> Apart from the nit, looks good to me.
>
> Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
Thanks for review!
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
