On Tue 21-06-22 08:47:29, Damien Le Moal wrote: > > diff --git a/include/linux/ioprio.h b/include/linux/ioprio.h > > index 61ed6bb4998e..519d51fc8902 100644 > > --- a/include/linux/ioprio.h > > +++ b/include/linux/ioprio.h > > @@ -66,11 +66,6 @@ static inline int get_current_ioprio(void) > > return prio; > > } > > > > -/* > > - * For inheritance, return the highest of the two given priorities > > - */ > > Nit: you could move this comment over the static function. But the name > makes it fairly obvious what it does :) Yeah, I didn't find it particularly useful, especially after ioprio_best() becomes pure min() so I've just deleted it... > > -extern int ioprio_best(unsigned short aprio, unsigned short bprio); > > - > > extern int set_task_ioprio(struct task_struct *task, int ioprio); > > > > #ifdef CONFIG_BLOCK > Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> Thanks for review! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR