On 6/20/22 10:56, Christoph Hellwig wrote:
On Mon, Jun 20, 2022 at 10:49:06AM +0200, Hannes Reinecke wrote:
I wish we could have blktests for tearing down device-drivers; doing a
regression test here will be really hard.
The problem with a remove is that while we have a generic device remove
attribute, it:
a) isn't always in the same place relatively to the disk
b) once removed we have no generic way to add the device back for
further testing
nvme/032 has basic remove testing for nvme, and I think I can also
wire up my scsi bind/unbind testing for blktests using scsi_debug without
too much effort. But that still isn't exactly a generic test.
Precisely my sentiment. This patchset is touch a _lot_ of drivers, and
modifying the removal path of each.
Looking obvious from initial glance, but as usual the devil's in the
detail. Or, to quote my QA maxim:
'The only way to be ensure it works is to ensure it works.'
But anyway, probably just wishful thinking.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
