Re: [PATCH 5/6] block: simplify disk shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/19/22 08:05, Christoph Hellwig wrote:
Set the queue dying flag and call blk_mq_exit_queue from del_gendisk for
all disks that do not have separately allocated queues, and thus remove
the need to call blk_cleanup_queue for them.

Rename blk_cleanup_disk to blk_mq_destroy_queue to make it clear that
this function is intended only for separately allocated blk-mq queues.

This saves an extra queue freeze for devices without a separately
allocated queue.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
---
  block/blk-core.c                    | 37 -------------------------
  block/blk-mq.c                      | 43 +++++++++++++++++++++++++++--
  block/blk-sysfs.c                   |  5 ----
  block/blk.h                         |  3 ++
  block/bsg-lib.c                     |  4 +--
  block/genhd.c                       | 23 ++++++++-------
  drivers/block/ataflop.c             |  1 -
  drivers/block/loop.c                |  1 -
  drivers/block/mtip32xx/mtip32xx.c   |  2 --
  drivers/block/rnbd/rnbd-clt.c       |  2 +-
  drivers/block/sx8.c                 |  4 +--
  drivers/block/virtio_blk.c          |  1 -
  drivers/block/z2ram.c               |  1 -
  drivers/cdrom/gdrom.c               |  1 -
  drivers/memstick/core/ms_block.c    |  1 -
  drivers/memstick/core/mspro_block.c |  1 -
  drivers/mmc/core/block.c            |  1 -
  drivers/mmc/core/queue.c            |  1 -
  drivers/nvme/host/apple.c           |  2 +-
  drivers/nvme/host/core.c            |  1 -
  drivers/nvme/host/fc.c              | 12 ++++----
  drivers/nvme/host/pci.c             |  2 +-
  drivers/nvme/host/rdma.c            | 12 ++++----
  drivers/nvme/host/tcp.c             | 12 ++++----
  drivers/nvme/target/loop.c          | 12 ++++----
  drivers/s390/block/dasd.c           |  2 +-
  drivers/s390/block/dasd_genhd.c     |  4 +--
  drivers/scsi/scsi_lib.c             |  6 ++--
  drivers/scsi/scsi_sysfs.c           |  2 +-
  drivers/scsi/sd.c                   |  4 +--
  drivers/scsi/sr.c                   |  4 +--
  drivers/ufs/core/ufshcd.c           |  4 +--
  include/linux/blk-mq.h              |  3 ++
  include/linux/blkdev.h              |  4 +--
  34 files changed, 105 insertions(+), 113 deletions(-)

(This will come back to haunt me once I have to do a backport ...)
(But anyway.)

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@xxxxxxx			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux