Re: [PATCH 3/6] block: remove QUEUE_FLAG_DEAD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 19, 2022 at 07:07:20AM -0700, Bart Van Assche wrote:
>> -	if (blk_queue_dead(q))
>> +	if (blk_queue_dying(q))
>>   		return -ENOENT;
>
> I'm missing an explanation of why this patch forbids triggering a queue run 
> in the dying state. "dying" means that allocation of new requests will 
> fail. Unless if something fundamentally has changed in the block layer it 
> should still be safe to trigger a queue run in the "dying" state.

It is safe, but not worth having another queue state for given that we
can otherwise remove the QUEUE_FLAG_DEAD bit.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux