Re: [PATCH blktests] nvme/039: avoid module loads for various transport types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jun 10, 2022 / 16:08, Alan Adamson wrote:
> Reviewed-by: Alan Adamson <alan.adamson@xxxxxxxxxx>
> 
> 
> > On Jun 10, 2022, at 5:15 AM, Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx> wrote:
> > 
> > The test case nvme/039 does not depend on nvme transport type and does
> > not require modules for the transport types. The _nvme_requires call in
> > requires() loads the modules and those modules are left unloaded after
> > the test case run. This causes failures of following nvmeof-mp test runs
> > with message:
> > 
> >  modprobe: FATAL: Module nvmet is in use.
> > 
> > To avoid the unnecessary module loads, remove _nvme_requires call.
> > Instead, just check existence of nvme command.
> > 
> > Fixes: 9accb5f86670 ("tests/nvme: add tests for error logging")
> > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>

Alan, Chaitanya, thank you for the reviewed-by tags. I've applied it.

-- 
Shin'ichiro Kawasaki



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux