On Tue, May 31, 2022 at 11:12:45AM +0000, Shinichiro Kawasaki wrote: > > +_have_driver() > > +{ > > + local modname="${1/-/_}" > > + > > + if [ ! -d "/sys/module/${modname}" ] && ! modprobe -q ${modname}; then > > Nit: double quote is required for ${modname} to make shellcheck happy. It is aready quote when assigning to modname, so there is no actual need. But I'll add the quotes to make the checker happy.