On 6/1/22 12:04 AM, Christoph Hellwig wrote: > On Tue, May 31, 2022 at 02:58:00PM -0400, Mike Snitzer wrote: >> Yes, we need the above to fix the crash. Does it also make sense to >> add this? > > Can we just stop treating bio_sets so sloppily and make the callers > handle their lifetime properly? No one should have to use > bioset_initialized (or double free bio_sets). Yes, that was my point in the previous email - get rid of bioset_initialized() and just fixup dm, which is the only user of it. There really should be no need to have this kind of conditional checking and initialization. -- Jens Axboe
