On 2022/5/20 17:37, Shinichiro Kawasaki wrote: > The change looks good for me other than a nit: after applying this patch, > shellcheck complains: > > $ make check > shellcheck -x -e SC2119 -f gcc check new common/* \ > tests/*/rc tests/*/[0-9]*[0-9] > tests/nvmeof-mp/001:30:20: note: Double quote to prevent globbing and word splitting. [SC2086] > tests/nvmeof-mp/001:34:19: note: Double quote to prevent globbing and word splitting. [SC2086] > > As the commit changes value of the variable $expected, its references need > double quotes: Hi Shinichiro, Good catch. I will fix it as you suggested. Best Regards, Xiao Yang
