On Thu, May 19, 2022 at 04:20:40PM +0200, Hannes Reinecke wrote: >> >> No, it does not fix that commit, which is perfectly fine. It fixes >> the recently added second caller of blkcg_get_fc_appid, and James >> has just resent a new version of that which fixes this properly. > > Really? blk-cgroup.h provides the function declaration > blkcg_get_fc_appid() unconditionally, but the implementation > for blkcg_get_fc_appid() depends on CONFIG_CGROUP. Take a look at the IS_ENABLED macro that we have for a few years now. > Neither of which is changed by James patchset. > > And besides, the first version is already merged. > > Am I missing something? https://lore.kernel.org/linux-scsi/20220519123110.17361-1-jsmart2021@xxxxxxxxx/T/#t
